[Behavioral Analytics] Temporary remove GeoIP Processor from pipeline #96159
Conversation
…ily load the geo database
| @@ -57,13 +57,6 @@ | |||
| "ignore_missing": true | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
@eyalkoren May I ask a few questions? This pipeline is now managed by the IndexTemplate registry
- do I need to increase the
REGISTRY_VERSIONfor this change?
There was a problem hiding this comment.
Generally speaking- yes. As long as you use the same pipeline ID, I believe it won't be upgraded if it is already installed otherwise.
In your specific case, maybe it is not required (and even not preferred), because the geoip DB has already been downloaded, so you might as well keep using its processor...
I guess you need to decide whether you enforce proper version maintenance (and increase the version) or make an exception in this case (not increase the version- then only new clusters will use this form).
I hope this makes sense...
There was a problem hiding this comment.
Thanks for the answer! Yep as this is only a temporary change and will have a further change before 8.9 release, I will keep the version number the same.
There was a problem hiding this comment.
So if your further change restores the pipeline state to be the same as it was before, this is indeed not required.
However, if after all your pipeline (or any other component installed through your registry) changes, then version should be increased, otherwise it won't be upgraded in rolling upgrades.
elasticsearchmachine
added
the
needs:triage
jimczi
added
:EnterpriseSearch/Application
|
Pinging @elastic/ent-search-eng (Team:Enterprise Search) |
Due to the impact in tests #96129, we want to remove the geoip processor and re-introduce it for 8.9, once we have figured a path to lazily load the geoip database that the geo-ip processor requires.